linux-kernel - Re: [PATCH] fs: switch order of CAP_DAC_OVERRIDE and CAP_DAC_READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1703111205200.20298@namei.org>
Date:   Sat, 11 Mar 2017 12:05:30 +1100 (AEDT)
From:   James Morris <jmorris@...ei.org>
To:     Stephen Smalley <sds@...ho.nsa.gov>
cc:     viro@...iv.linux.org.uk, james.l.morris@...cle.com,
        serge@...lyn.com, paul@...l-moore.com, john.johansen@...onical.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org, selinux@...ho.nsa.gov
Subject: Re: [PATCH] fs: switch order of CAP_DAC_OVERRIDE and CAP_DAC_READ_SEARCH
 checks

On Fri, 10 Mar 2017, Stephen Smalley wrote:

> generic_permission() presently checks CAP_DAC_OVERRIDE prior to
> CAP_DAC_READ_SEARCH.  This can cause misleading audit messages when
> using a LSM such as SELinux or AppArmor, since CAP_DAC_OVERRIDE
> may not be required for the operation.  Flip the order of the
> tests so that CAP_DAC_OVERRIDE is only checked when required for
> the operation.
> 
> Signed-off-by: Stephen Smalley <sds@...ho.nsa.gov>


Acked-by: James Morris <james.l.morris@...cle.com>


-- 
James Morris
<jmorris@...ei.org>