linux-kernel - [PATCH RFC] mm/vmscan: donot retry shrink zones when memcg is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1489198798-6632-1-git-send-email-ysxie@foxmail.com>
Date:   Sat, 11 Mar 2017 10:19:58 +0800
From:   Yisheng Xie <ysxie@...mail.com>
To:     akpm@...ux-foundation.org, hannes@...xchg.org, mgorman@...e.de,
        vbabka@...e.cz, mhocko@...e.com, riel@...hat.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        xieyisheng1@...wei.com
Subject: [PATCH RFC] mm/vmscan: donot retry shrink zones when memcg is disabled

From: Yisheng Xie <xieyisheng1@...wei.com>

When we enter do_try_to_free_pages, the may_thrash is always clear, and
it will retry shrink zones to tap cgroup's reserves memory by setting
may_thrash when the former shrink_zones reclaim nothing.

However, if CONFIG_MEMCG=n, it should not do this useless retry at all,
for we do not have any cgroup's reserves memory to tap, and we have
already done hard work and made no progress.

Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
---
 mm/vmscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index bc8031e..b03ccc1 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2808,7 +2808,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
 		return 1;
 
 	/* Untapped cgroup reserves?  Don't OOM, retry. */
-	if (!sc->may_thrash) {
+	if (!sc->may_thrash && IS_ENABLED(CONFIG_MEMCG)) {
 		sc->priority = initial_priority;
 		sc->may_thrash = 1;
 		goto retry;
-- 
1.9.1