linux-kernel - Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201703111348.iFVyt3mM%fengguang.wu@intel.com>
Date:   Sat, 11 Mar 2017 13:07:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     kbuild-all@...org, Tejun Heo <tj@...nel.org>,
        Sekhar Nori <nsekhar@...com>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Kevin Hilman <khilman@...libre.com>,
        Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@....linux.org.uk>,
        Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        linux-ide@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, b.zolnierkie@...sung.com
Subject: Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver

Hi Bartlomiej,

[auto build test WARNING on tj-libata/for-next]
[also build test WARNING on v4.11-rc1 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Bartlomiej-Zolnierkiewicz/ata-add-Palmchip-BK3710-PATA-controller-driver/20170311-095152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git for-next
config: arm-davinci_all_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/ata/pata_bk3710.c: In function 'pata_bk3710_set_piomode':
>> drivers/ata/pata_bk3710.c:223:5: warning: 'cycle_time' may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (!cycle_time)
        ^

vim +/cycle_time +223 drivers/ata/pata_bk3710.c

   207		const u16 *id = adev->id;
   208		unsigned int cycle_time;
   209		int is_slave = adev->devno;
   210		const u8 pio = adev->pio_mode - XFER_PIO_0;
   211	
   212		if (id[ATA_ID_FIELD_VALID] & 2) {
   213			if (ata_id_has_iordy(id))
   214				cycle_time = id[ATA_ID_EIDE_PIO_IORDY];
   215			else
   216				cycle_time = id[ATA_ID_EIDE_PIO];
   217	
   218			/* conservative "downgrade" for all pre-ATA2 drives */
   219			if (pio < 3 && cycle_time < t->cycle)
   220				cycle_time = 0; /* use standard timing */
   221		}
   222	
 > 223		if (!cycle_time)
   224			cycle_time = t->cycle;
   225	
   226		pata_bk3710_setpiomode(base, pair, is_slave, cycle_time, pio);
   227	}
   228	
   229	static void pata_bk3710_chipinit(void __iomem *base)
   230	{
   231		/*

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (24160 bytes)