linux-kernel - Re: [PATCH 01/10] ALSA SoC MAX98927 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170312141102.fxigzia2nvfuli2d@rob-hp-laptop>
Date:   Sun, 12 Mar 2017 09:11:02 -0500
From:   Rob Herring <robh@...nel.org>
To:     Ryan Lee <ryans.lee@...imintegrated.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, mark.rutland@....com,
        perex@...ex.cz, tiwai@...e.com, arnd@...db.de,
        michael@...rulasolutions.com, oder_chiou@...ltek.com,
        yesanishhere@...il.com, jacob@...nage.engineering,
        Damien.Horsley@...tec.com, bardliao@...ltek.com,
        kuninori.morimoto.gx@...esas.com, petr@...ix.com, lars@...afoo.de,
        nh6z@...z.net, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 01/10] ALSA SoC MAX98927 driver - Initial release

On Fri, Mar 03, 2017 at 11:52:39PM +0900, Ryan Lee wrote:
> From: Ryan Lee <RyanS.Lee@...imintegrated.com>
> 
> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>
> ---
> 
> Initial release of ALSA SoC MAX98927 driver.
> 
>  .../devicetree/bindings/sound/max98927.txt         |   32 +

In addition to what Mark said, please split bindings to a separate 
patch.

>  sound/soc/codecs/Kconfig                           |    5 +
>  sound/soc/codecs/Makefile                          |    2 +
>  sound/soc/codecs/max98927.c                        |  954 +++++++++++++++
>  sound/soc/codecs/max98927.h                        | 1253 ++++++++++++++++++++
>  5 files changed, 2246 insertions(+)
>  create mode 100755 Documentation/devicetree/bindings/sound/max98927.txt
>  mode change 100644 => 100755 sound/soc/codecs/Kconfig
>  mode change 100644 => 100755 sound/soc/codecs/Makefile
>  create mode 100755 sound/soc/codecs/max98927.c
>  create mode 100755 sound/soc/codecs/max98927.h

These files should not be executable.

Rob