linux-kernel - Re: [PATCH] ASoC: cs35l35: trivial fix to indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58C56160.9070208@bfs.de>
Date:   Sun, 12 Mar 2017 15:55:28 +0100
From:   walter harms <wharms@....de>
To:     Colin King <colin.king@...onical.com>
CC:     Brian Austin <brian.austin@...rus.com>,
        Paul Handrigan <Paul.Handrigan@...rus.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Jiri Kosina <trivial@...nel.org>, alsa-devel@...a-project.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: cs35l35: trivial fix to indentation



Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Remove extraneous tab to correct the nesting level indentation
> 
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  sound/soc/codecs/cs35l35.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
>  
>  	for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
>  		cs35l35->supplies[i].supply = cs35l35_supplies[i];
> -		cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> +	cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>  


I have the feeling is better before the loop:

cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);

for (i = 0; i < cs35l35->num_supplies; i++)
     cs35l35->supplies[i].supply = cs35l35_supplies[i];

re,
 wh

>  	ret = devm_regulator_bulk_get(&i2c_client->dev,
>  			cs35l35->num_supplies,