linux-kernel - Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a125rioB5Cnoa7nR9Dz_pU5=x7=06_DvXEE-dTpOBiitQ@mail.gmail.com>
Date:   Mon, 13 Mar 2017 21:28:32 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Nicolas Pitre <nicolas.pitre@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>, stable@...r.kernel.org,
        Grygorii Strashko <grygorii.strashko@...com>,
        Thomas Gleixner <tglx@...utronix.de>,
        John Stultz <john.stultz@...aro.org>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

On Mon, Mar 13, 2017 at 9:09 PM, Nicolas Pitre <nicolas.pitre@...aro.org> wrote:
> On Mon, 13 Mar 2017, Arnd Bergmann wrote:
>
>> With posix timers having become optional, we get a build error with
>> the cpts time sync option of the CPSW driver:
>>
>> drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts':
>> drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean 'ptp_classifier_init'? [-Werror=implicit-function-declaration]
>>
>> It really makes no sense to build this driver if we can't use PTP,
>> so it's better to go back to 'select PTP_1588_CLOCK' but instead
>> add a dependency on POSIX_TIMERS. Adding 'depends on PTP_1588_CLOCK'
>> might also work, but has the risk of circular dependencies when
>> mixed with other drivers using 'imply'.
>
> Could you elaborate on that risk please?

I have seen many circular dependencies in the past that tend to be of type

config FOO
     depends on A
     select B

config BAR
     select A
     depends on B

The best way to avoid this problem is to only ever use either 'select' or
'depends on' for any given dependency, but not both. In this case, almost
all references to PTP_1588_CLOCK use 'select' or 'implies', so I don't
want to introduce any more 'depends on'.

     Arnd