linux-kernel - Re: [PATCH] PM / QOS: Remove the global notifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2efy0c17f.fsf@baylibre.com>
Date:   Mon, 13 Mar 2017 14:32:20 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>,
        Rafael Wysocki <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        linaro-kernel <linaro-kernel@...ts.linaro.org>,
        "linux-pm\@vger.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH] PM / QOS: Remove the global notifiers

Ulf Hansson <ulf.hansson@...aro.org> writes:

> On 13 March 2017 at 17:01, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>> On 22 February 2017 at 09:28, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>>> They were never used in the kernel, not sure why they got merged into
>>> the kernel though. Get rid of them.
>>
>> commit b66213cdb002b08b29603d488c451dfe25e2ca20
>> Author: Jean Pihet <j-pihet@...com>
>> Date:   Thu Aug 25 15:35:47 2011 +0200
>>
>>     PM QoS: Add global notification mechanism for device constraints
>>
>>     Add a global notification chain that gets called upon changes to the
>>     aggregated constraint value for any device.
>>     The notification callbacks are passing the full constraint request data
>>     in order for the callees to have access to it. The current use is for the
>>     platform low-level code to access the target device of the constraint.
>>
>>     Signed-off-by: Jean Pihet <j-pihet@...com>
>>     Reviewed-by: Kevin Hilman <khilman@...com>
>>     Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
>>
>> It was a while ago since they were added, but it seems like
>
> Slipped on the keyboard, sorry for the noise.
>
> I was about to say, that it was a while ago these were added, but
> still not being used. Thus let's remove them.
>
> Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Agreed.  If we still have no users, let's remove them.

Acked-by: Kevin Hilman <khilman@...libre.com>

Kevin