linux-kernel - Re: [PATCH] dma-engine: Fix array index out of bounds warning in __get_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4io=wi1-v7cHocK1USe1MWhaP2gvwt990boPcqMbL5UVw@mail.gmail.com>
Date:   Mon, 13 Mar 2017 14:52:55 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Vinod Koul <vinod.koul@...el.com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Grant Grundler <grundler@...omium.org>
Subject: Re: [PATCH] dma-engine: Fix array index out of bounds warning in __get_unmap_pool()

On Mon, Mar 13, 2017 at 2:30 PM, Matthias Kaehlcke <mka@...omium.org> wrote:
> This fixes the following warning when building with clang and
> CONFIG_DMA_ENGINE_RAID=n :
>
> drivers/dma/dmaengine.c:1102:11: error: array index 2 is past the end of the array (which contains 1 element) [-Werror,-Warray-bounds]
>                 return &unmap_pool[2];
>                         ^          ~
> drivers/dma/dmaengine.c:1083:1: note: array 'unmap_pool' declared here
> static struct dmaengine_unmap_pool unmap_pool[] = {
> ^
> drivers/dma/dmaengine.c:1104:11: error: array index 3 is past the end of the array (which contains 1 element) [-Werror,-Warray-bounds]
>                 return &unmap_pool[3];
>                         ^          ~
> drivers/dma/dmaengine.c:1083:1: note: array 'unmap_pool' declared here
> static struct dmaengine_unmap_pool unmap_pool[] = {
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Reviewed-by: Dan Williams <dan.j.williams@...el.com>