linux-kernel - RE: [PATCH v2] phy: rcar-gen3-usb2: fix implementation for runtime PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PS1PR06MB1692AE431C1F92F39CBBAAF3D8250@PS1PR06MB1692.apcprd06.prod.outlook.com>
Date:   Mon, 13 Mar 2017 23:39:20 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "kishon@...com" <kishon@...com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v2] phy: rcar-gen3-usb2: fix implementation for runtime PM

Hi!

> From: Sergei Shtylyov
> Sent: Monday, March 13, 2017 8:57 PM
> 
> On 03/13/2017 12:39 PM, Yoshihiro Shimoda wrote:
> 
> > This patch fixes an issue that this driver doesn't take care of the runtime
> > PM. This code assumed that devm_phy_create() called pm_runtime_enable(dev),
> > but it misunderstood the dev_phy_create()'s specification.
> > This driver should call its own pm_runtime_pm() before dev_phy_create().
> 
>     You probably meant pm_runtime_enable()? Sorry for not noticing the 1st time...

Yes, I meant pm_runtime_enable(). Thank you for the review again and again.

Best regards,
Yoshihiro Shimoda