linux-kernel - Re: [PATCH v2 10/21] x86/xen: split off smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9479bcbf-da2a-fa4f-915d-5c0ef50ab1d3@suse.com>
Date:   Mon, 13 Mar 2017 08:37:42 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        xen-devel@...ts.xenproject.org
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Andrew Jones <drjones@...hat.com>
Subject: Re: [PATCH v2 10/21] x86/xen: split off smp_hvm.c

On 02/03/17 18:53, Vitaly Kuznetsov wrote:
> Move PVHVM related code to smp_hvm.c. Drop 'static' qualifier from
> xen_smp_send_reschedule(), xen_smp_send_call_function_ipi(),
> xen_smp_send_call_function_single_ipi(), these functions will be moved to
> common smp code when smp_pv.c is split.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

One nit below, with this addressed:

Reviewed-by: Juergen Gross <jgross@...e.com>

> ---
>  arch/x86/xen/Kconfig   |  4 ++++
>  arch/x86/xen/Makefile  |  1 +
>  arch/x86/xen/smp.c     | 57 +++----------------------------------------------
>  arch/x86/xen/smp.h     |  3 +++
>  arch/x86/xen/smp_hvm.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 69 insertions(+), 54 deletions(-)
>  create mode 100644 arch/x86/xen/smp_hvm.c
> 

> diff --git a/arch/x86/xen/smp.h b/arch/x86/xen/smp.h
> index a059adb..bf36e79 100644
> --- a/arch/x86/xen/smp.h
> +++ b/arch/x86/xen/smp.h
> @@ -14,6 +14,9 @@ extern void xen_smp_intr_free(unsigned int cpu);
>  extern int xen_smp_intr_init_pv(unsigned int cpu);
>  extern void xen_smp_intr_free_pv(unsigned int cpu);
>  
> +extern void xen_smp_send_reschedule(int cpu);
> +extern void xen_smp_send_call_function_ipi(const struct cpumask *mask);
> +extern void xen_smp_send_call_function_single_ipi(int cpu);

Could you please drop the "extern" qualifier when adding new function
prototypes? I know this just follows the style of the file, but I'd
prefer not to add new instances.


Juergen