linux-kernel - RE: Bad DT binding (hisi-pcie-almost-ecam)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EE11001F9E5DDD47B7634E2F8A612F2E2047B79C@FRAEML521-MBX.china.huawei.com>
Date:   Mon, 13 Mar 2017 09:34:54 +0000
From:   Gabriele Paoloni <gabriele.paoloni@...wei.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Mark Rutland <mark.rutland@....com>,
        "liudongdong (C)" <liudongdong3@...wei.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Wangzhou (B)" <wangzhou1@...ilicon.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Bad DT binding (hisi-pcie-almost-ecam)

Hi Geert

[...]

> >          {
> > -           .compatible = "hisilicon,pcie-almost-ecam",
> > +         .compatible = "hisilicon,pcie-almost-ecam-hip06",
> 
> Shouldn't that be "hisilicon,hip06-pcie-almost-ecam"?
> 
> > +         .data           = (void *) &hisi_pcie_platform_ops,
> > + },
> > + {
> > +         .compatible = "hisilicon,pcie-almost-ecam-hip07",
> 
> Shouldn't that be "hisilicon,hip07-pcie-almost-ecam"?

Indeed prefixing the SoC name is more consistent and it looks better

Many thanks
Gab

> 
> >                  .data       = (void *) &hisi_pcie_platform_ops,
> >          },
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a
> hacker. But
> when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds