linux-kernel - Re: [PATCH] staging: lustre fix constant comparision style issue in lu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170313121110.GD4136@mwanda>
Date:   Mon, 13 Mar 2017 15:11:10 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Craig Inches <Craig@...iginches.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, oleg.drokin@...el.com,
        andreas.dilger@...el.com, lustre-devel@...ts.lustre.org
Subject: Re: [PATCH] staging: lustre fix constant comparision style issue in
 lu_object.h

On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote:
> On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote:
> > This patch resolves the "Comparisons should place the constant on
> > the right side of the test" found with checkpatch tool.
> 
> Both are constants, I think checkpatch is the thing that is wrong here,
> don't you agree?

Sort of constant-ish...  The sizeof(*value) changes each time the macro
is used.  I feel like checkpatch is right.

regads,
dan carpenter