linux-kernel - Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2017 13:01:38 +0000
From:   Jason Cooper <jason@...edaemon.net>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Gregory Clement <gregory.clement@...e-electrons.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device
 tree bindings

Hi Geert,

On Sun, Mar 12, 2017 at 02:16:49PM +0100, Geert Uytterhoeven wrote:
> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> Cc: Gregory Clement <gregory.clement@...e-electrons.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> ---
> Please apply this patch directly if you want to be involved in device
> tree binding documentation for your subsystem.
> 
> v2:
>   - No changes.
> 
> Impact on next-20170310:
> 
> +Jason Cooper <jason@...edaemon.net> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Andrew Lunn <andrew@...n.ch> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Sebastian Hesselbarth <sebastian.hesselbarth@...il.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Gregory Clement <gregory.clement@...e-electrons.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>  Rob Herring <robh+dt@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  Mark Rutland <mark.rutland@....com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> +linux-arm-kernel@...ts.infradead.org (moderated list:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>  devicetree@...r.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  linux-kernel@...r.kernel.org (open list)
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6428d3c82fce9670..ce461fefec6c9463 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1486,6 +1486,7 @@ M:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
>  M:	Gregory Clement <gregory.clement@...e-electrons.com>
>  L:	linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
>  S:	Maintained
> +F:	Documentation/devicetree/bindings/soc/dove/

I'm not opposed to the idea, but I'm not seeing how we can do this
completely.  What you've added only covers dove soc bindings.  There's
orion5x, kirkwood, and all the newer mvebu socs.  Not to mention a lot
of IP blocks we care about that aren't SoC- or Marvell-specific.

The dts files have a much more clear file pattern -> maintainer pairing.
Perhaps we should make checkpatch smarter?  e.g. compatible strings
found in changed binding docs are searched for in dts{i} files.  Hits
are mapped to maintainers.

thoughts?

thx,

Jason.