linux-kernel - Re: [PATCH] mm: mark gup_pud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170313052113.4mgqf7a6vsfyeocg@black.fi.intel.com>
Date:   Mon, 13 Mar 2017 08:21:13 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     linux-mm@...ck.org, mhocko@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: mark gup_pud_range as unused

On Mon, Mar 13, 2017 at 04:58:37PM +1300, Chris Packham wrote:
> The last caller to gup_pud_range was removed in commit c2febafc6773
> ("mm: convert generic code to 5-level paging"). Mark it as unused to
> silence a warning from gcc.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
> I saw this warning when compiling 4.11-rc2 with -Werror. An equally valid fix
> would be to remove the function entirely but I went for the less invasive
> approach.

Thanks for report. But real fix is to call gup_pud_range() from
gup_p4d_range(), not itself.

I'll post a fix.
Reported-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
Reported-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

-- 
 Kirill A. Shutemov