linux-kernel - Re: [PATCH] perf sort: Segmentation fault of basic block cycles sort dimension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170313144159.GM2750@kernel.org>
Date:   Mon, 13 Mar 2017 11:41:59 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     changbin.du@...el.com
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf sort: Segmentation fault of basic block cycles sort
 dimension

Em Mon, Mar 13, 2017 at 04:31:48PM +0800, changbin.du@...el.com escreveu:
> From: Changbin Du <changbin.du@...el.com>
> 
> Skip the sample which doesn't have branch_info to avoid segmentation
> fault occurrence.
> 
> The fault can be reproduced by:
> perf record -a
> perf report -F cycles

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Changbin Du <changbin.du@...el.com>
> ---
>  tools/perf/util/sort.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 0ff6222..b6db140 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -846,6 +846,9 @@ static int hist_entry__mispredict_snprintf(struct hist_entry *he, char *bf,
>  static int64_t
>  sort__cycles_cmp(struct hist_entry *left, struct hist_entry *right)
>  {
> +	if (!left->branch_info || !right->branch_info)
> +		return cmp_null(left->branch_info, right->branch_info);
> +
>  	return left->branch_info->flags.cycles -
>  		right->branch_info->flags.cycles;
>  }
> @@ -853,6 +856,8 @@ sort__cycles_cmp(struct hist_entry *left, struct hist_entry *right)
>  static int hist_entry__cycles_snprintf(struct hist_entry *he, char *bf,
>  				    size_t size, unsigned int width)
>  {
> +	if (!he->branch_info)
> +		return scnprintf(bf, size, "%-.*s", width, "N/A");
>  	if (he->branch_info->flags.cycles == 0)
>  		return repsep_snprintf(bf, size, "%-*s", width, "-");
>  	return repsep_snprintf(bf, size, "%-*hd", width,
> -- 
> 2.7.4