linux-kernel - Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <928d1178-e04a-3e78-4a7a-36127321a949@gmail.com>
Date:   Mon, 13 Mar 2017 09:47:23 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     sean.wang@...iatek.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, matthias.bgg@...il.com,
        robh+dt@...nel.org, mark.rutland@....com
Cc:     devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        davem@...emloft.net, Landen.Chao@...iatek.com, keyhaede@...il.com,
        objelf@...il.com
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530
 binding

On 03/13/2017 09:11 AM, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> Add device-tree binding for Mediatek MT7530 switch.
> 
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>  .../devicetree/bindings/net/dsa/mt7530.txt         | 94 ++++++++++++++++++++++
>  1 file changed, 94 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/dsa/mt7530.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/mt7530.txt b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
> new file mode 100644
> index 0000000..0e50dbf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
> @@ -0,0 +1,94 @@
> +Mediatek MT7530 Ethernet switch
> +================================
> +
> +Required properties:
> +
> +- compatible: Must be compatible = "mediatek,mt7530";
> +- #address-cells: Must be 1
> +- #size-cells: Must be 0
> +- mediatek,ethsys: Phandle to the syscon node that handles the reset.
> +- mediatek,ethernet: Phandle to the syscon node that Mediatek ethernet driver
> +	provides that handles the TRGMII setup used by the switch.
> +	See
> +	Documentation/devicetree/bindings/net/mediatek-net.txt for the detailed
> +	setup on mediatek ethernet.

This seems redundant with the CPU port's ethernet phandle here.
-- 
Florian