linux-kernel - Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo50UXh9Xqnf0nsx+tntS57N1v=xHbhRkddPDOVtgas4xgA@mail.gmail.com>
Date:   Mon, 13 Mar 2017 18:09:17 +0000
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Rob Clark <robdclark@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        stable <stable@...r.kernel.org>, freedreno@...ts.freedesktop.org
Subject: Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs

On 13 March 2017 at 17:00, Rob Clark <robdclark@...il.com> wrote:
> On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann <arnd@...db.de> wrote:
>> The newly added a5xx support fails to build when debugfs is diabled:
>>
>> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:4: error: 'struct msm_gpu_funcs' has no member named 'show'
>> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:11: error: 'a5xx_show' undeclared here (not in a function); did you mean 'a5xx_irq'?
>>
>> This adds a missing #ifdef.
>>
>> Fixes: b5f103ab98c7 ("drm/msm: gpu: Add A5XX target support")
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> I thought I had picked this one up already, but I guess my brain was
> playing tricks on me.. I've pushed this to msm-next for now and will
> cherry-pick this over to a -fixes branch when I send fixes for 4.11..
>
Sean sent a similar patch last week. I think he picked it (alongside
others) in drm-misc-fixes.
Haven't checked though ;-)

-Emil