linux-kernel - [tip:x86/urgent] x86/platform: Remove warning message for duplicate NMI handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-0d443b70cc92d741cbc1dcbf1079897b3d8bc3cc@git.kernel.org>
Date:   Mon, 13 Mar 2017 12:48:50 -0700
From:   tip-bot for Mike Travis <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mingo@...nel.org, a.p.zijlstra@...llo.nl, dimitri.sivanich@....com,
        tony.ernst@....com, frank.ramsay@....com,
        linux-kernel@...r.kernel.org, russ.anderson@....com, hpa@...or.com,
        mike.travis@....com, tglx@...utronix.de, dzickus@...hat.com
Subject: [tip:x86/urgent] x86/platform: Remove warning message for duplicate
 NMI handlers

Commit-ID:  0d443b70cc92d741cbc1dcbf1079897b3d8bc3cc
Gitweb:     http://git.kernel.org/tip/0d443b70cc92d741cbc1dcbf1079897b3d8bc3cc
Author:     Mike Travis <mike.travis@....com>
AuthorDate: Tue, 7 Mar 2017 15:08:42 -0600
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 13 Mar 2017 20:45:18 +0100

x86/platform: Remove warning message for duplicate NMI handlers

Remove the WARNING message associated with multiple NMI handlers as
there are at least two that are legitimate.  These are the KGDB and the
UV handlers and both want to be called if the NMI has not been claimed
by any other NMI handler.

Use of the UNKNOWN NMI call chain dramatically lowers the NMI call rate
when high frequency NMI tools are in use, notably the perf tools.  It is
required on systems that cannot sustain a high NMI call rate without
adversely affecting the system operation.

Signed-off-by: Mike Travis <mike.travis@....com>
Reviewed-by: Dimitri Sivanich <dimitri.sivanich@....com>
Cc: Don Zickus <dzickus@...hat.com>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Russ Anderson <russ.anderson@....com>
Cc: Frank Ramsay <frank.ramsay@....com>
Cc: Tony Ernst <tony.ernst@....com>
Link: http://lkml.kernel.org/r/20170307210841.730959611@asylum.americas.sgi.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

---
 arch/x86/kernel/nmi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
index f088ea4..a723ae94 100644
--- a/arch/x86/kernel/nmi.c
+++ b/arch/x86/kernel/nmi.c
@@ -166,11 +166,9 @@ int __register_nmi_handler(unsigned int type, struct nmiaction *action)
 	spin_lock_irqsave(&desc->lock, flags);
 
 	/*
-	 * most handlers of type NMI_UNKNOWN never return because
-	 * they just assume the NMI is theirs.  Just a sanity check
-	 * to manage expectations
+	 * Indicate if there are multiple registrations on the
+	 * internal NMI handler call chains (SERR and IO_CHECK).
 	 */
-	WARN_ON_ONCE(type == NMI_UNKNOWN && !list_empty(&desc->head));
 	WARN_ON_ONCE(type == NMI_SERR && !list_empty(&desc->head));
 	WARN_ON_ONCE(type == NMI_IO_CHECK && !list_empty(&desc->head));