linux-kernel - Re: [PATCH 2/4] misc: ds1682: Add OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0SWPKkuYwx3tVjRWZ-8J21uXro0ZmFN3_vApSC9JX_yw@mail.gmail.com>
Date:   Tue, 14 Mar 2017 21:46:37 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 2/4] misc: ds1682: Add OF device ID table

On Tue, Mar 14, 2017 at 4:16 PM, Javier Martinez Canillas
<javier@....samsung.com> wrote:

> +static const struct of_device_id ds1682_of_match[] = {
> +       { .compatible = "dallas,ds1682", },
> +       {}
> +};
> +MODULE_DEVICE_TABLE(of, ds1682_of_match);
> +
>  static struct i2c_driver ds1682_driver = {
>         .driver = {
>                 .name = "ds1682",
> +               .of_match_table = of_match_ptr(ds1682_of_match),
>         },
>         .probe = ds1682_probe,
>         .remove = ds1682_remove,

This will cause a warning if CONFIG_OF is disabled, since ds1682_of_match
becomes unused in this case. Please remove the of_match_ptr() around
the reference to ds1682_of_match.

    Arnd