linux-kernel - Re: [RESEND PATCH] ARM: omap2: mark omap_init_rng as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170314212746.GH20572@atomide.com>
Date:   Tue, 14 Mar 2017 14:27:46 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] ARM: omap2: mark omap_init_rng as __init

* Arnd Bergmann <arnd@...db.de> [170314 14:27]:
> I found this section mismatch when building with an older
> compiler release:
> 
> WARNING: vmlinux.o(.text+0x3051c): Section mismatch in reference from the function omap_init_rng() to the function .init.text:omap_device_build()
> 
> Obviously this one function should be __init as well. Normally
> we don't get a warning as the function gets inlined into its
> caller.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Tony Lindgren <tony@...mide.com>
> ---
> Originally submitted on Dec 16. Tony, could you pick it up for v4.12?
> We haven't started merging stuff yet, and I forgot to apply it earlier
> but want to get it out of my backlog.

OK will pick it up thanks.

Tony

> ---
>  arch/arm/mach-omap2/devices.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 3fdb94599184..473951203104 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -121,7 +121,7 @@ static inline void omap_init_mcspi(void) {}
>   *
>   * Bind the RNG hwmod to the RNG omap_device.  No return value.
>   */
> -static void omap_init_rng(void)
> +static void __init omap_init_rng(void)
>  {
>  	struct omap_hwmod *oh;
>  	struct platform_device *pdev;
> -- 
> 2.9.0
>