linux-kernel - Re: [PATCH V7 4/7] LPC: Support the device-tree LPC host on Hip06/Hip07 (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58C796B7.9060505@hisilicon.com>
Date:   Tue, 14 Mar 2017 15:07:35 +0800
From:   "zhichang.yuan" <yuanzhichang@...ilicon.com>
To:     Julia Lawall <julia.lawall@...6.fr>
CC:     <catalin.marinas@....com>, <will.deacon@....com>,
        <robh+dt@...nel.org>, <frowand.list@...il.com>,
        <bhelgaas@...gle.com>, <rafael@...nel.org>, <mark.rutland@....com>,
        <rjw@...ysocki.net>, <arnd@...db.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-acpi@...r.kernel.org>, <lorenzo.pieralisi@....com>,
        <benh@...nel.crashing.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <devicetree@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <minyard@....org>, <liviu.dudau@....com>, <zourongrong@...il.com>,
        <john.garry@...wei.com>, <gabriele.paoloni@...wei.com>,
        <zhichang.yuan02@...il.com>, <kantyzc@....com>,
        <xuwei5@...ilicon.com>, <kbuild-all@...org>
Subject: Re: [PATCH V7 4/7] LPC: Support the device-tree LPC host on
 Hip06/Hip07 (fwd)

Hi, Julia,


On 2017/3/14 13:37, Julia Lawall wrote:
> Line 460 looks suspicious.  Can tmprange be different than range but not
> be an ERR_PTR?  If so, lpcdev->io_host will have an invalid value.
> 

Thanks for your pointing out!
You are right!

miss a line of 'return 0;' 

if (tmprange != range) {
    kfree(range);
    if (IS_ERR(tmprange))
        return -EFAULT;
    return 0;
}

Thanks again!
Zhichang 

> julia
> 
> ---------- Forwarded message ----------
> Date: Tue, 14 Mar 2017 13:12:05 +0800
> From: kbuild test robot <fengguang.wu@...el.com>
> To: kbuild@...org
> Cc: Julia Lawall <julia.lawall@...6.fr>
> Subject: Re: [PATCH V7 4/7] LPC: Support the device-tree LPC host on Hip06/Hip07
> 
> Hi zhichang.yuan,
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.11-rc2 next-20170310]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/zhichang-yuan/LPC-legacy-ISA-I-O-support/20170314-114635
> :::::: branch date: 85 minutes ago
> :::::: commit date: 85 minutes ago
> 
>>> drivers/bus/hisi_lpc.c:465:19-24: ERROR: reference preceded by free on line 460
> 
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout 4e05ad6c3274fa75c903c7809ef0b51329a31ab2
> vim +465 drivers/bus/hisi_lpc.c
> 
> 4e05ad6c zhichang.yuan 2017-03-13  454  	range->flags = IO_HOST_INDIRECT;
> 4e05ad6c zhichang.yuan 2017-03-13  455  	range->size = LPC_BUS_IO_SIZE;
> 4e05ad6c zhichang.yuan 2017-03-13  456  	range->hw_start = LPC_MIN_BUS_RANGE;
> 4e05ad6c zhichang.yuan 2017-03-13  457
> 4e05ad6c zhichang.yuan 2017-03-13  458  	tmprange = register_libio_range(range);
> 4e05ad6c zhichang.yuan 2017-03-13  459  	if (tmprange != range) {
> 4e05ad6c zhichang.yuan 2017-03-13 @460  		kfree(range);
> 4e05ad6c zhichang.yuan 2017-03-13  461  		if (IS_ERR(tmprange))
> 4e05ad6c zhichang.yuan 2017-03-13  462  			return -EFAULT;
> 4e05ad6c zhichang.yuan 2017-03-13  463  	}
> 4e05ad6c zhichang.yuan 2017-03-13  464
> 4e05ad6c zhichang.yuan 2017-03-13 @465  	lpcdev->io_host = range;
> 4e05ad6c zhichang.yuan 2017-03-13  466
> 4e05ad6c zhichang.yuan 2017-03-13  467  	return 0;
> 4e05ad6c zhichang.yuan 2017-03-13  468  }
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
> .
>