lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <959bfbfb-177f-3e92-0a2c-1e283966b961@codethink.co.uk>
Date:   Tue, 14 Mar 2017 09:40:07 +0000
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     Rafał Miłecki <zajec5@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Cc:     Mark Rutland <mark.rutland@....com>,
        Baruch Siach <baruch@...s.co.il>,
        Eric Anholt <eric@...olt.net>,
        Thierry Reding <thierry.reding@...il.com>,
        Rafał Miłecki <rafal@...ecki.pl>,
        Alexandre Courbot <gnurou@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Kevin Hilman <khilman@...libre.com>,
        Lee Jones <lee@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-snps-arc@...ts.infradead.org,
        Stephen Warren <swarren@...dotorg.org>,
        Marc Zyngier <marc.zyngier@....com>,
        Ray Jui <rjui@...adcom.com>,
        linux-rpi-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Barry Song <baohua@...nel.org>,
        Scott Branden <sbranden@...adcom.com>,
        Vineet Gupta <vgupta@...opsys.com>,
        Uwe Kleine-König <kernel@...gutronix.de>,
        Carlo Caione <carlo@...one.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH] clocksource: add missing line break to error messages

On 09/03/17 09:47, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
>
> Printing with pr_* functions requires adding line break manually.
>
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>

I've had a quick look over and there are no obvious errors.

I wonder if the of_iomap() and related calls should print an
error if they fail as all the examples here are of the form
of:

	ptr = of_iomap(reource)
	if (!ptr) {
		pr_err("cannot remap resource\n");
		...
		return ERR;
	}

Maybe we should look into this post this patch series.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ