linux-kernel - Re: [PATCH] ks7010: adding parenthesis to macro argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170314104151.GE4187@mwanda>
Date:   Tue, 14 Mar 2017 13:41:51 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Pushkar Jambhlekar <pushkar.iit@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        sayli karnik <karniksayli1995@...il.com>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        Nick Rosbrook <nrosbrook@...l.smcvt.edu>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ks7010: adding parenthesis to macro argument

On Tue, Mar 14, 2017 at 03:01:50AM -0700, Pushkar Jambhlekar wrote:
> Hi Dan,
> 
> I am trying to fix warnings by "checkpatch.pl". Even though it is not
> super exciting, no harm to follow correct way.
> 

The harm is that it takes something that's already terrible and makes it
even more unreadable.

regards,
dan carpenter