linux-kernel - Re: [PATCH v2] f2fs: restrict write IO alignment condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07e43857-1387-eb9b-478d-57d2f14d81e4@huawei.com>
Date:   Tue, 14 Mar 2017 19:32:16 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>
CC:     <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>, <chao@...nel.org>
Subject: Re: [PATCH v2] f2fs: restrict write IO alignment condition

On 2017/3/14 4:05, Jaegeuk Kim wrote:
> On 03/13, Chao Yu wrote:
>> We should only align start offset of bio with defined IO_SIZE for below
>> conditions:
>> a. mode=lfs mount option
>> b. write IOs
>> c. Out-place-update
>> d. non-meta pages
>>
>> Signed-off-by: Chao Yu <yuchao0@...wei.com>
>> ---
>>  fs/f2fs/data.c | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
>> index 1375fef11146..53fe79c70406 100644
>> --- a/fs/f2fs/data.c
>> +++ b/fs/f2fs/data.c
>> @@ -190,6 +190,9 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi,
>>  			current->plug && (type == DATA || type == NODE))
>>  			blk_finish_plug(current->plug);
>>  
>> +		if (!test_opt(sbi, LFS))
>> +			goto submit_io;
> 
> The parse_options in fill_super checks this.

You're right, I missed that one...

> 
>> +
>>  		if (type != DATA && type != NODE)
>>  			goto submit_io;
>>  
>> @@ -395,11 +398,12 @@ int f2fs_submit_page_mbio(struct f2fs_io_info *fio)
>>  		__submit_merged_bio(io);
>>  alloc_new:
>>  	if (io->bio == NULL) {
>> -		if ((fio->type == DATA || fio->type == NODE) &&
>> +		if (test_opt(sbi, LFS) &&
>> +			!is_read && (fio->type == DATA || fio->type == NODE) &&
> 
> The missing case is !is_read, here?
> But, actually, DATA and NODE don't issue any read commands at all.

Correct, let me add BUG_ON here. :)

Thanks,

> 
> Thanks,
> 
>>  				fio->new_blkaddr & F2FS_IO_SIZE_MASK(sbi)) {
>>  			err = -EAGAIN;
>> -			if (!is_read)
>> -				dec_page_count(sbi, WB_DATA_TYPE(bio_page));
>> +			f2fs_bug_on(sbi, fio->new_blkaddr == fio->old_blkaddr);
>> +			dec_page_count(sbi, WB_DATA_TYPE(bio_page));
>>  			goto out_fail;
>>  		}
>>  		io->bio = __bio_alloc(sbi, fio->new_blkaddr,
>> -- 
>> 2.8.2.295.g3f1c1d0
> 
> .
>