linux-kernel - Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170314120539.GT15842@lunn.ch>
Date:   Tue, 14 Mar 2017 13:05:39 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Matthias May <matthias.may@...atec.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Jason Cobham <jcobham@...stertangent.com>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time

> Hi
> The never ever seeing R/W failure on MDIO bus is not exactly accurate.
> We had with art (atheros calibration tool) the problem that interrupts
> were being disabled which lead to MDIO operations running into
> timout/failing.

Yes, i've seen similar with power management bugs for the MDIO
driver. But you get a cascade of failures, lots of warnings and error
prints, it is clear something bad has happened, and the switch is in
an inconsistent state. So having one more debug print which is also
inconsistent does no really harm.

Anyway, this whole conversation has taken more effort than just making
this simple change to remove a few lines of code. So lets drop it and
move on.

    Andrew