linux-kernel - Re: [Intel-gfx] [linux-mmotm] i915_gem_userptr_get_pages: possible circular locking dependency detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170314134103.GI2118@nuc-i3427.alporthouse.com>
Date:   Tue, 14 Mar 2017 13:41:03 +0000
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [Intel-gfx] [linux-mmotm] i915_gem_userptr_get_pages: possible
 circular locking dependency detected

On Tue, Mar 14, 2017 at 10:21:09PM +0900, Sergey Senozhatsky wrote:
> Hello,
> 
> [  530.698622] ======================================================
> [  530.698623] WARNING: possible circular locking dependency detected
> [  530.698626] 4.11.0-rc2-mm1-dbg-00167-gdb8a9941614c-dirty #222 Not tainted
> [  530.698627] ------------------------------------------------------
> [  530.698628] Xorg/343 is trying to acquire lock:
> [  530.698630]  (&mm->mmap_sem){++++++}, at: [<ffffffffa057e085>] i915_gem_userptr_get_pages+0x60/0x29c [i915]
> [  530.698702] 
>                but task is already holding lock:
> [  530.698703]  (&obj->mm.lock){+.+.+.}, at: [<ffffffffa0572d78>] __i915_gem_object_get_pages+0x21/0x62 [i915]
> [  530.698763] 
>                which lock already depends on the new lock.

Yup, just seen it myself. This particular cycle is a non-issue, but
there is another possiblity for a mmap_sem recursion in the ggtt fault
handler.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre