lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Mar 2017 15:56:43 +0100 From: Jiri Olsa <jolsa@...hat.com> To: Andi Kleen <andi@...stfloor.org> Cc: acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com> Subject: Re: [PATCH 01/13] perf, tools, stat: Factor out callback for collecting event values On Fri, Mar 10, 2017 at 01:24:34PM -0800, Andi Kleen wrote: SNIP > + > +struct aggr_data { > + u64 ena, run, val; > + int id; > + int nr; > + int cpu; > +}; > + > +static void aggr_cb(struct perf_evsel *counter, void *data, bool first) > +{ > + struct aggr_data *ad = data; > + int cpu, s2; > + > + for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) { > + struct perf_counts_values *counts; > + > + s2 = aggr_get_id(evsel_list->cpus, cpu); why do use evsel_list instead of perf_evsel__cpus(counter), which is in the original/removed code? this patch is about adding collect_data.. if you want to choose this part, please make it clear in separate patch thanks, jirka
Powered by blists - more mailing lists