linux-kernel - Re: [PATCH] engine: mv_xor: remove redundant null check on cd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170314023039.GY2843@localhost>
Date:   Tue, 14 Mar 2017 08:00:40 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Dan Williams <dan.j.williams@...el.com>, dmaengine@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] engine: mv_xor: remove redundant null check on cd

On Wed, Mar 01, 2017 at 02:07:21PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The check to see if cd is null is redundant, pdata->channels is
> never null at this point, and hence &pdata->channels[i] cannot
> be null, so remove the null check.
> 
> Detected by CoverityScan, CID#1357194 ("Logically Dead Code")

Applied after fixing subsystem name

-- 
~Vinod