linux-kernel - Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170314212713.1afb7a9f@free-electrons.com>
Date:   Tue, 14 Mar 2017 21:27:13 +0100
From:   Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Stephen Boyd <stephen.boyd@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing

Hello,

On Tue, 14 Mar 2017 14:30:05 -0500, Bjorn Helgaas wrote:
> On Tue, Mar 14, 2017 at 12:08:51PM -0700, Stephen Boyd wrote:
> > This code assigns variables that are never used. Remove them.
> > 
> > Reported-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > Cc: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> > Signed-off-by: Stephen Boyd <stephen.boyd@...aro.org>  
> 
> I love removing unused code!  Applied to pci/host-aardvark for v4.12,
> thanks!

Why? I have already sent a patch that also does this (and much more!) a
number of times already, and it has never been applied. See:

  [PATCH v3 1/3] pci: pci-aardvark: move to MSI handling using generic MSI support

v1 on September 1st, 2016
v2 on December 23th, 2016
v3 on February 28th, 2017

Best regards,

Thomas

-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com