linux-kernel - Re: [PATCH v2 2/5] mm: parallel free pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a2501d29d70$7eb0f530$7c12df90$@alibaba-inc.com>
Date:   Wed, 15 Mar 2017 17:42:42 +0800
From:   "Hillf Danton" <hillf.zj@...baba-inc.com>
To:     "'Aaron Lu'" <aaron.lu@...el.com>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Cc:     "'Dave Hansen'" <dave.hansen@...el.com>,
        "'Tim Chen'" <tim.c.chen@...el.com>,
        "'Andrew Morton'" <akpm@...ux-foundation.org>,
        "'Ying Huang'" <ying.huang@...el.com>
Subject: Re: [PATCH v2 2/5] mm: parallel free pages


On March 15, 2017 5:00 PM Aaron Lu wrote: 
>  void tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
>  {
> +	struct batch_free_struct *batch_free, *n;
> +
s/*n/*next/

>  	tlb_flush_mmu(tlb);
> 
>  	/* keep the page table cache within bounds */
>  	check_pgt_cache();
> 
> +	list_for_each_entry_safe(batch_free, n, &tlb->worker_list, list) {
> +		flush_work(&batch_free->work);

Not sure, list_del before free?

> +		kfree(batch_free);
> +	}
> +
>  	tlb_flush_mmu_free_batches(tlb->local.next, true);
>  	tlb->local.next = NULL;
>  }