linux-kernel - Re: [PATCH 05/19] gpio: 104-dio-48e: make use of raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZxkYC4oJmWFhT_APpgZb5dzmExhyywgohRe8CyfFR+dQ@mail.gmail.com>
Date:   Wed, 15 Mar 2017 10:54:54 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Julia Cartwright <julia@...com>
Cc:     William Breathitt Gray <vilhelm.gray@...il.com>,
        Alexandre Courbot <gnurou@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 05/19] gpio: 104-dio-48e: make use of raw_spinlock variants

On Thu, Mar 9, 2017 at 5:21 PM, Julia Cartwright <julia@...com> wrote:

> The 104-dio-48e gpio driver currently implements an irq_chip for
> handling interrupts; due to how irq_chip handling is done, it's
> necessary for the irq_chip methods to be invoked from hardirq context,
> even on a a real-time kernel.  Because the spinlock_t type becomes a
> "sleeping" spinlock w/ RT kernels, it is not suitable to be used with
> irq_chips.
>
> A quick audit of the operations under the lock reveal that they do only
> minimal, bounded work, and are therefore safe to do under a raw spinlock.
>
> Signed-off-by: Julia Cartwright <julia@...com>

Patch applied with Williams ACK.

Yours,
Linus Walleij