linux-kernel - Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2439695.Eb3n5AH02E@diego>
Date:   Wed, 15 Mar 2017 11:10:54 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Chris Zhong <zyw@...k-chips.com>
Cc:     linux-rockchip@...ts.infradead.org,
        Mark Yao <mark.yao@...k-chips.com>,
        David Airlie <airlied@...ux.ie>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi

Am Mittwoch, 15. März 2017, 17:55:23 CET schrieb Chris Zhong:
> Hi Heiko
> 
> On 03/15/2017 05:03 PM, Heiko Stübner wrote:
> > Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong:
> >> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver,
> >> add the description for this clock.
> >> 
> >> Signed-off-by: Chris Zhong <zyw@...k-chips.com>
> >> ---
> >> 
> >>   .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt      
> >>   | 2
> >> 
> >> +- 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git
> >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip
> >> .t
> >> xt
> >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip
> >> .t
> >> xt index 188f6f7..7e17a60 100644
> >> ---
> >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip
> >> .t
> >> xt +++
> >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip
> >> .t
> >> 
> >> xt @@ -10,7 +10,7 @@ Required properties:
> >>   - interrupts: Represent the controller's interrupt to the CPU(s).
> >>   - clocks, clock-names: Phandles to the controller's pll reference
> >>   
> >>     clock(ref) and APB clock(pclk). For RK3399, a phy config clock
> >> 
> >> -  (phy_cfg) is additional required. As described in [1].
> >> +  (phy_cfg) and a grf clock(grf) are additional required. As described
> >> in
> >> [1].
> > 
> > your "grf" clock is optional, as it is not present on all socs (like the
> > rk3288) so should probably move to a separate section and not be in the
> > required properties
> 
> For RK3399, the grf clock is required, according to the advice provided
> by rob[0],
> put it into "required properties " is better.
> [0] https://patchwork.kernel.org/patch/9220187/

ok, but it should probably be made clear, that this is rk3399-specific