linux-kernel - Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01911ed2-d64b-6f81-5ca2-7efa9b63d70f@ti.com>
Date:   Wed, 15 Mar 2017 17:12:17 +0530
From:   Vignesh R <vigneshr@...com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during
 request_irq()



On Tuesday 14 March 2017 09:29 PM, Andy Shevchenko wrote:
> On Tue, Mar 14, 2017 at 3:44 PM, Vignesh R <vigneshr@...com> wrote:
>> On Monday 13 March 2017 01:35 AM, Andy Shevchenko wrote:
>>> On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R <vigneshr@...com> wrote:
>>>> Passing "serial" as name during request_irq() results in all serial port
>>>> irqs have same name. This does not help much to easily identify which
>>>> irq belongs to which serial port instance. Therefore pass dev_name()
>>>> during request_irq() so that better identifiable name is listed for
>>>> serial ports in cat /proc/interrupts output.
>>>>
>>>> Output of cat /proc/interrupts
>>>> Before this patch:
>>>>  26:        689          0     GICv2 309 Edge      serial
>>>> After this patch:
>>>>  26:        696          0     GICv2 309 Edge      2530c00.serial
> 
>>  But, this change is making interrupt name more descriptive
> 
> It doesn't in PCI case, it makes it worse.
> 
> (The world is not DT-centric)
> 
>>> Besides that imagine what would be the name of PCI device here.
>>> I would suggest adding ID if you need one in a form like
>>> "serial%d", where ID may or may not be supplied by the actual 8250 drivers.
>>>
>>
>> Are you suggesting to use serial_index() as ID?
> 
> Yes.
> 

Ok thanks, I will send on incremental fix as this patch is already applied.

-- 
Regards
Vignesh