linux-kernel - Re: [PATCH 1/7] mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Mar 2017 12:19:48 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     Nicolas Ferre <nicolas.ferre@...el.com>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        linux-arm-kernel@...ts.infradead.org,
        Samuel Ortiz <sameo@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] mfd: syscon: atmel-smc: Add new helpers to ease SMC
 regs manipulation

On Tue, 14 Mar 2017, Boris Brezillon wrote:

> On Tue, 14 Mar 2017 17:00:03 +0000
> Lee Jones <lee.jones@...aro.org> wrote:
> 
> > On Mon, 20 Feb 2017, Boris Brezillon wrote:
> > 
> > > These new helpers + macro definitions are meant to replace the old ones
> > > which are unpractical to use.
> > > 
> > > Note that the macros and function prefixes have been intentionally
> > > changed to ATMEL_[H]SMC_XX and atmel_[h]smc_ to reflect the fact that
> > > this IP is also embedded in avr32 SoCs (and not only in at91 ones).  
> > 
> > I'm going to NACK this patch.
> > 
> > I don't see any reason why all those functions have to be inline and
> > shoved into a header file.
> 
> Because those are simple conversion helpers, and I thought a
> dedicated C file was not required, but I can move them into a C file
> and export these functions using EXPORT_SYMBOL_GPL() if you prefer.
> 
> Would that work for you?

I think that would be better TBH.  Those functions aren't all that
simple.  There is certainly too much meat on the bones for me to be
happy for them to be shoved into a header file.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog