linux-kernel - Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170315122300.jwuogngm6obgvz5z@dell>
Date:   Wed, 15 Mar 2017 12:23:00 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Tony Lindgren <tony@...mide.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning
 to pr_warn

On Tue, 14 Mar 2017, Joe Perches wrote:

> On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote:
> > On Thu, 16 Feb 2017, Joe Perches wrote:
> > > To enable eventual removal of pr_warning
> []
> > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> []
> > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata,
> > >  	}
> > >  	if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
> > >  		if (!order)
> > > -			pr_warning("TWL4030: Bad order of scripts (sleep "\
> > > -					"script before wakeup) Leads to boot"\
> > > -					"failure on some boards\n");
> > > +			pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n");
> > 
> > Is 80 chars considered the lessor sin?
> 
> Splitting logging messages into multiple lines is non preferred.
> 
> Documentation/process/coding-style.rst:
> 
> Breaking long lines and strings:
> 
> never break user-visible strings such as
> printk messages, because that breaks the ability to grep for them.

Right, I'm aware of this.  I'm also aware of the other rule we have
where lines are not to exceed 80 chars.  Hence my question; "is the 80
chars rule the lessor sin of the two".

Rock <=> hard place

Actually I would say that the error message sub-optimal and could, in
fact be edited to be more succinct, thus not breaking any rules. 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog