linux-kernel - Re: [RESEND PATCH] drm: amd: remove broken include path

Open Source and information security mailing list archives

Message-ID: <CADnq5_MkjAA_ikYYc4jYp=NqH7WSk0o2kf0b1pdqEf+vaCLcLQ@mail.gmail.com>
Date:   Wed, 15 Mar 2017 10:20:20 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] drm: amd: remove broken include path

On Tue, Mar 14, 2017 at 5:27 PM, Arnd Bergmann <arnd@...db.de> wrote:
> The AMD ACP driver adds "-I../acp -I../acp/include" to the gcc command
> line, which makes no sense, since these are evaluated relative to the
> build directory. When we build with "make W=1", they instead cause
> a warning:
>
> cc1: error: ../acp/: No such file or directory [-Werror=missing-include-dirs]
> cc1: error: ../acp/include: No such file or directory [-Werror=missing-include-dirs]
> cc1: all warnings being treated as errors
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.o' failed
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_kms.o' failed
>
> This removes the subdir-ccflags variable that evidently did not
> serve any purpose here.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.  thanks!

Alex

> ---
> Originally submitted in June 2016. All other patches for this warning got
> merged, once this gets in we can turn on the warning flag for everyone.
> ---
>  drivers/gpu/drm/amd/acp/Makefile | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/acp/Makefile b/drivers/gpu/drm/amd/acp/Makefile
> index 8363cb57915b..8a08e81ee90d 100644
> --- a/drivers/gpu/drm/amd/acp/Makefile
> +++ b/drivers/gpu/drm/amd/acp/Makefile
> @@ -3,6 +3,4 @@
>  # of AMDSOC/AMDGPU drm driver.
>  # It provides the HW control for ACP related functionalities.
>
> -subdir-ccflags-y += -I$(AMDACPPATH)/ -I$(AMDACPPATH)/include
> -
>  AMD_ACP_FILES := $(AMDACPPATH)/acp_hw.o
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives