[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170315145118.GA30463@bill-the-cat>
Date: Wed, 15 Mar 2017 10:51:18 -0400
From: Tom Rini <trini@...sulko.com>
To: linux-kbuild@...r.kernel.org
Cc: Michal Marek <mmarek@...e.com>, linux-kernel@...r.kernel.org,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>
Subject: Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full
path
On Sat, Mar 11, 2017 at 11:59:22PM +0000, Tom Rini wrote:
> On some architectures, such as arm64, KBUILD_IMAGE is not a full path
> but instead just the build target. The builddeb script handles this
> case correctly today and will try arch/$ARCH/boot/$KBUILD_IMAGE so we
> can just borrow that logic and adapt it slightly for spec file syntax.
>
> Cc: Michal Marek <mmarek@...e.com>
> Cc: linux-kbuild@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> Signed-off-by: Tom Rini <trini@...sulko.com>
> ---
> It is currently a mixed-bag on if architectures will use a build target
> (arm, arm64, arc are certainly by inspection and a few others 'may') or
> a full path (x86, blackfin, s390). Given that builddeb gets this case
> correct, I think changing mkspec is the right way to go here.
I found https://patchwork.kernel.org/patch/9442211/ today and I see that
it was brought up again just before I sent my patch. I just want to
point out that 9442211 doesn't address arm, arc, and sh and they will
still not have a functional rpm build target. This is at least probably
important for arm. Of course all of those could also be addressed with
a patch similar to 9442211, and my main concern is making sure
everything gets fixed one way or another. Thanks!
--
Tom
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)
Powered by blists - more mailing lists