linux-kernel - Re: [PATCH v5 3/4] dt-bindings: phy: Add support for QMP phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170315203456.pxroh7nir2iwll3o@rob-hp-laptop>
Date:   Wed, 15 Mar 2017 15:34:56 -0500
From:   Rob Herring <robh@...nel.org>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     kishon@...com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, mark.rutland@....com,
        sboyd@...eaurora.org, bjorn.andersson@...aro.org,
        srinivas.kandagatla@...aro.org
Subject: Re: [PATCH v5 3/4] dt-bindings: phy: Add support for QMP phy

On Thu, Mar 09, 2017 at 02:37:20PM +0530, Vivek Gautam wrote:
> Qualcomm chipsets have QMP phy controller that provides
> support to a number of controller, viz. PCIe, UFS, and USB.
> Adding dt binding information for the same.
> 
> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> Cc: Rob Herring <robh@...nel.org>
> ---
> 
> Hi Rob,
> I have removed your Acked-by tag because of the change in bindings.
> Please consider adding your Ack again if you are fine with these
> updated bindings.
> 
> Changes since v4:
>  - Added bindings for child nodes. Each phy lane is represented by child
>    node with its own register space (for tx, rx and pcs blocks), and clocks
>    and resets for power control facility.
>  - Removed register space and lane offsets for tx, rx and pcs blocks from
>    qmp phy node.
>  - #phy-cells is now part of each child node and thus must be 0.
>  - Added information on list of mandatory clocks and resets for each phy.
> 
> Changes since v3:
>  - Added #clock-cells = <1>, indicating that phy is a clock provider.
> 
> Changes since v2:
>  - Removed binding for "ref_clk_src" since we don't request this
>    clock in the driver.

Humm, sounds suspicious. You should describe clocks connected to the h/w 
block, not what the driver uses (currently).

>  - Addressed s/ref_clk/ref. Don't need to add '_clk' suffix to clock names.
>  - Using 'phy' for the node name.
> 
> Changes since v1:
>  - New patch, forked out of the original driver patch:
>    "phy: qcom-qmp: new qmp phy driver for qcom-chipsets"
>  - Added 'Acked-by' from Rob.
>  - Updated bindings to include mem resource as a list of
>    offset - length pair for serdes block and for each lane.
>  - Added a new binding for 'lane-offsets' that contains offsets
>    to tx, rx and pcs blocks from each lane base address.
> 
>  .../devicetree/bindings/phy/qcom-qmp-phy.txt       | 106 +++++++++++++++++++++
>  1 file changed, 106 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt

Acked-by: Rob Herring <robh@...nel.org>