linux-kernel - Re: [PATCH v2] Power: supply: sbs-charger: simplified bool function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170315212341.r5w4wzyjriuo55qh@earth>
Date:   Wed, 15 Mar 2017 22:23:41 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Daniel Perez <danielperezdeandres@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        nicolassaenzj@...il.com
Subject: Re: [PATCH v2] Power: supply: sbs-charger: simplified bool function

Hi Daniel,

On Wed, Feb 15, 2017 at 04:46:21PM +0100, Daniel Perez wrote:
> v1 -> v2:
>  - given Joe Perches' comment, I've further simplified the syntax
>    of the bool function, removing the ternary conditional
> 
> Signed-off-by: Daniel Perez <danielperezdeandres@...il.com>

Thanks, queued. Please move the Version history below ---, so that
it does not end up in the commit. I fixed that while applying.

-- Sebastian

> ---
>  drivers/power/supply/sbs-charger.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/power/supply/sbs-charger.c b/drivers/power/supply/sbs-charger.c
> index 353765a..15947db 100644
> --- a/drivers/power/supply/sbs-charger.c
> +++ b/drivers/power/supply/sbs-charger.c
> @@ -137,10 +137,7 @@ static enum power_supply_property sbs_properties[] = {
>  
>  static bool sbs_readable_reg(struct device *dev, unsigned int reg)
>  {
> -	if (reg < SBS_CHARGER_REG_SPEC_INFO)
> -		return false;
> -	else
> -		return true;
> +	return reg >= SBS_CHARGER_REG_SPEC_INFO;
>  }
>  
>  static bool sbs_volatile_reg(struct device *dev, unsigned int reg)
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)