linux-kernel - Re: [PATCH 2/2] dt-bindings: power/supply: Add support for xmega16d4-battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170315215411.mychw72dcgo4bdhp@earth>
Date:   Wed, 15 Mar 2017 22:54:11 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Enric Balletbo Serra <eballetbo@...il.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-pm@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 2/2] dt-bindings: power/supply: Add support for
 xmega16d4-battery

Hi,

On Thu, Feb 23, 2017 at 06:44:59PM +0100, Enric Balletbo Serra wrote:
> Ooops, sorry I forget to add the device tree maintainers so
> 
> CC'ing Rob Herring and Mark Rutland
> 
> 
> 2017-02-23 18:38 GMT+01:00 Enric Balletbo i Serra
> <enric.balletbo@...labora.com>:
> > Add the documentation for binding of Toby Churchill SBS battery monitor
> > driver. The device is connected via SPI and is able to report different
> > battery characteristics.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > ---
> >  .../devicetree/bindings/power/supply/xmega16d4-battery.txt   | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt b/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
> > new file mode 100644
> > index 0000000..c76db67
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
> > @@ -0,0 +1,12 @@
> > +Binding for the Toby Churchill SBS battery monitor
> > +
> > +Required properties :
> > + - compatible : "tcl,xmega16d4-battery"

The same naming issue, that I mentioned in the driver patch applies
here. Also you should reference the standard spi binding document
for properties like spi-max-frequency.

-- Sebastian

> > +Example:
> > +
> > +       battery: smart-battery@0 {
> > +               compatible = "tcl,xmega16d4-battery";
> > +               reg = <0>;
> > +               spi-max-frequency = <100000>;
> > +       };

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)