linux-kernel - Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff45704c3fcc601bf67149bd69cfdc23@codeaurora.org>
Date:   Wed, 15 Mar 2017 15:57:09 -0700
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     James Bottomley <James.Bottomley@...senpartnership.com>
Cc:     Tomas Winkler <tomas.winkler@...el.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Vinayak Holikatti <vinholikatti@...il.com>,
        Christoph Hellwig <hch@....de>,
        Yaniv Gardi <ygardi@...eaurora.org>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-scsi-owner@...r.kernel.org
Subject: Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

On 2017-03-15 10:26, James Bottomley wrote:
> On Mon, 2017-03-13 at 17:19 -0700, Subhash Jadavani wrote:
>> On 2017-03-12 03:22, Tomas Winkler wrote:
>> > Fix compilation warning
>> >
>> > drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned
>> > expression < 0 is always false [-Wtype-limits]
>> > if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX))
>> >
>> > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
>> > ---
>> >  drivers/scsi/ufs/ufshcd.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> > index 1359913bf840..e8c26e6e6237 100644
>> > --- a/drivers/scsi/ufs/ufshcd.c
>> > +++ b/drivers/scsi/ufs/ufshcd.c
>> > @@ -7642,7 +7642,7 @@ static inline ssize_t
>> > ufshcd_pm_lvl_store(struct
>> > device *dev,
>> >  	if (kstrtoul(buf, 0, &value))
>> >  		return -EINVAL;
>> >
>> > -	if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX))
>> > +	if (value >= UFS_PM_LVL_MAX)
>> >  		return -EINVAL;
>> >
>> >  	spin_lock_irqsave(hba->host->host_lock, flags);
>> 
>> LGTM.
>> Reviewed-by: Subhash Jadavani <subhashj@...aurora.org>
> 
> Mis-spelling someone else's email can be cut and paste; mis-spelling
> your own might be the early indications of an identity crisis.
> 
> We do cut and paste these tags, so getting your own name right for the
> purposes of git history is useful.
> 
> James

Oops, sorry for this. If you haven't already corrected this:
Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>



-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project