linux-kernel - Re: [PATCH v4 11/18] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170315230229.woqzt6dthzmpuohd@earth>
Date:   Thu, 16 Mar 2017 00:02:29 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Quentin Schulz <quentin.schulz@...e-electrons.com>
Cc:     mark.rutland@....com, thomas.petazzoni@...e-electrons.com,
        devicetree@...r.kernel.org, lars@...afoo.de,
        linux-pm@...r.kernel.org, liam@...workimprov.net,
        linux-sunxi@...glegroups.com, linux@...linux.org.uk,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        bonbons@...ux-vserver.org, robh+dt@...nel.org, icenowy@...c.xyz,
        pmeerw@...erw.net, knaack.h@....de,
        maxime.ripard@...e-electrons.com, wens@...e.org,
        lee.jones@...aro.org, jic23@...nel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 11/18] dt-bindings: power: supply: add AXP20X/AXP22X
 battery DT binding

Hi,

On Wed, Mar 15, 2017 at 11:41:07PM +0100, Quentin Schulz wrote:
> Hi,
> 
> On 15/03/2017 23:28, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Wed, Mar 15, 2017 at 11:55:30AM +0100, Quentin Schulz wrote:
> >> The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply.
> >>
> >> This patch adds the DT binding documentation for the battery power
> >> supply which gets various data from the PMIC, such as the battery status
> >> (charging, discharging, full, dead), current max limit, current current,
> >> battery capacity (in percentage), voltage max and min limits, current
> >> voltage and battery capacity (in Ah).
> >>
> >> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com>
> >> Acked-by: Chen-Yu Tsai <wens@...e.org>
> >> Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > 
> > I suggest to do "s/battery-power-supply/battery-fuel-gauge/g"
> > 
> 
> The IP is way more than a simple fuel gauge, you have info about the
> voltage, current, you can set different things, even though you have the
> percentage of the battery returned by the PMIC.

Most chips sold under the label battery-fuel-gauges actually give
you that kind of information ;)

> Does it really make sense to rename it that way?

If everybody is fine with it I don't mind too much.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)