linux-kernel - Re: [PATCH v1 1/1] platform/x86: intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 22:12:15 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
Cc:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Andy Shevchenko <andy@...radead.org>,
        Zha Qipeng <qipeng.zha@...el.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping size

On Thu, Mar 16, 2017 at 8:13 PM, Rajneesh Bhardwaj
<rajneesh.bhardwaj@...el.com> wrote:
> On Thu, Mar 16, 2017 at 06:05:39PM +0200, Andy Shevchenko wrote:
>> On Thu, Mar 16, 2017 at 4:52 PM, Rajneesh Bhardwaj
>> <rajneesh.bhardwaj@...el.com> wrote:
>> > On Wed, Mar 15, 2017 at 08:32:53PM -0700, Kuppuswamy Sathyanarayanan wrote:
>> >> Mapping entire GCR mem region in this driver creates
>> >> mem region request conflict in sub devices that depend
>> >> on PMC. This creates driver probe failure in devices like
>> >> iTC0_wdt and telemetry device.
>>
>> > iTCO_WDT driver needs to check the BIT4 (NO_REBOOT) of PMC_CFG register
>> > (Offset: 0x1008) and this falls in GCR space.
>>
>> Are we talking about ACPI-enabled platform?

> IIUC, you are referring to WDT enumerated by ACPI tables (WDAT, WDRT etc) ?
>
> On APL/BXT i think we pass the resource mapping to iTCO_WDT driver since
> acpi_has_watchdog provides the required protection. For non ACPI-enabled
> platforms we have this issue since iTCO_WDT driver anyway tries resource
> mapping when the iTCO_version >=2.

And driver with necessary stuff should be already in upstream.

https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/tree/drivers/mfd/lpc_ich.c?h=watchdog-next#n552

Or it's not enough?

-- 
With Best Regards,
Andy Shevchenko