linux-kernel - Re: [PATCH 5/5 v3] ftrace/x86-32: Add -mfentry support to x86_32 with DYNAMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170316172535.039e2fdc@gandalf.local.home>
Date:   Thu, 16 Mar 2017 17:25:35 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...capital.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 5/5 v3] ftrace/x86-32: Add -mfentry support to x86_32
 with DYNAMIC_FTRACE set

On Thu, 16 Mar 2017 16:00:43 -0500
Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> On Thu, Mar 16, 2017 at 04:40:36PM -0400, Steven Rostedt wrote:
> > [
> >   Fengguang Wu's bot told me that it failed to compile, as ftrace_32.S
> >   always gets compiled (as does ftrace_64.S). And the content needs to
> >   be protected within the #ifdef.
> > ]  
> 
> Why not instead make their compilation conditional in the Makefile?
> 
> Like:
> 
> obj-$(CONFIG_FUNCTION_TRACER)	+= ftrace_$(bits).o
> 

That's another patch ;-)

I just followed suit with what was already there.

I'll add a 6th patch to clean that up.

-- Steve