linux-kernel - Re: [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c304f4f4-8e4a-f716-ecd0-7f3ff7980dbc@attotech.com>
Date:   Thu, 16 Mar 2017 17:09:35 -0400
From:   Bradley Grove <bgrove@...otech.com>
To:     Colin King <colin.king@...onical.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer

On 03/15/2017 12:46 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> buffer is a pointer to the static char array event_buffer and
> therefore can never be null, so the check is redundant. Remove it.
>
> Detected by CoverityScan, CID#1077556 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/scsi/esas2r/esas2r_log.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c
> index a82030a..65fdf22 100644
> --- a/drivers/scsi/esas2r/esas2r_log.c
> +++ b/drivers/scsi/esas2r/esas2r_log.c
> @@ -130,11 +130,6 @@ static int esas2r_log_master(const long level,
>
>  		spin_lock_irqsave(&event_buffer_lock, flags);
>
> -		if (buffer == NULL) {
> -			spin_unlock_irqrestore(&event_buffer_lock, flags);
> -			return -1;
> -		}
> -
>  		memset(buffer, 0, buflen);
>
>  		/*
>

Thanks,

Acked-by: Bradley Grove <bgrove@...otech.com>

This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc. If you have reason to believe that you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this electronic transmission is strictly prohibited. If you have reason to believe that you have received this transmission in error, please notify ATTO immediately by return e-mail and delete and destroy this communication.