linux-kernel - [PATCH] Input: synaptics-rmi4 - Report slot as inactive when contact is a palm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1489708591-4320-1-git-send-email-aduggan@synaptics.com>
Date:   Thu, 16 Mar 2017 16:56:31 -0700
From:   Andrew Duggan <aduggan@...aptics.com>
To:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Andrew Duggan <aduggan@...aptics.com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Cameron Gutman <aicommander@...il.com>,
        Thorsten Leemhuis <linux@...mhuis.info>,
        Christopher Heiny <cheiny@...aptics.com>,
        Nick Dyer <nick@...anahar.org>
Subject: [PATCH] Input: synaptics-rmi4 - Report slot as inactive when contact is a palm

When the firmware identifies a contact as a palm the driver sets the tool
type to MT_TOOL_PALM, but sets the slot state as active. Reporting the
palm as active results in userspace input libraries considering the palm
as a valid contact. Touchpads which previously were using hid-multitouch
are now not suppressing palms when switching to the RMI4 driver. This
change fixes palm rejection when using the RMI4 driver.

Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
Tested-by: Cameron Gutman <aicommander@...il.com>
---
 drivers/input/rmi4/rmi_2d_sensor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/rmi4/rmi_2d_sensor.c b/drivers/input/rmi4/rmi_2d_sensor.c
index 8bb866c..8d1f295 100644
--- a/drivers/input/rmi4/rmi_2d_sensor.c
+++ b/drivers/input/rmi4/rmi_2d_sensor.c
@@ -80,7 +80,8 @@ void rmi_2d_sensor_abs_report(struct rmi_2d_sensor *sensor,
 		input_mt_slot(input, slot);
 
 	input_mt_report_slot_state(input, obj->mt_tool,
-				   obj->type != RMI_2D_OBJECT_NONE);
+				   (obj->type != RMI_2D_OBJECT_NONE)
+				   && (obj->type != RMI_2D_OBJECT_PALM));
 
 	if (obj->type != RMI_2D_OBJECT_NONE) {
 		obj->x = sensor->tracking_pos[slot].x;
-- 
2.7.4