[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <698eeeeb-2181-28b3-08dd-018fc5ccd011@gmail.com>
Date: Wed, 15 Mar 2017 19:10:56 -0600
From: David Ahern <dsahern@...il.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Anton Blanchard <anton@...abs.org>,
David Miller <davem@...emloft.net>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...nel.org>,
Hemant Kumar <hemant@...ux.vnet.ibm.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Steven Rostedt <rostedt@...dmis.org>,
Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
Wang Nan <wangnan0@...wei.com>,
Namhyung Kim <namhyung@...nel.org>,
Jiri Olsa <jolsa@...nel.org>,
alexander.shishkin@...ux.intel.com, sparclinux@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: change uprobe_events default ? Was: [PATCH] perf: Rename
CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
On 3/15/17 7:06 PM, Arnaldo Carvalho de Melo wrote:
> Added more people to the CC list.
>
> Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
>> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
>>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
>>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
>>> use the plurals.
>
>> this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
>> this is key feature that all distros enable, so having default 'n'
>> is kinda saying that it's not something that should be turned on
>> or used widely. which is obviously not the case.
>> imo it's time to change it to 'y'.
>> Thoughts?
>
> Agreed, I also found it strange that it was disabled by default when I
> recently did a 'make oldconfig' :-\
Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it
should default on.
Powered by blists - more mailing lists