linux-kernel - Re: [PATCH] vc04_services: Fixing coding guideline error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMvNc9BT7_5Hu2iFxd1cbEY64jzQxCEZhdgU8cm_p_SDnZFZhQ@mail.gmail.com>
Date:   Thu, 16 Mar 2017 11:01:38 +0530
From:   Pushkar Jambhlekar <pushkar.iit@...il.com>
To:     Stephen Warren <swarren@...dotorg.org>, Lee Jones <lee@...nel.org>,
        Eric Anholt <eric@...olt.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Zoran <mzoran@...wfest.net>,
        Daniel Stone <daniels@...labora.com>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Noralf Trønnes <noralf@...nnes.org>,
        Stafford Horne <shorne@...il.com>,
        Pushkar Jambhlekar <pushkar.iit@...il.com>,
        popcornmix <popcornmix@...il.com>
Cc:     "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vc04_services: Fixing coding guideline error

Any comment?

On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar
<pushkar.iit@...il.com> wrote:
> Fixing 'if' block coding style. '{' should follow 'if' for multiline block
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@...il.com>
> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> index 48984ab..ca896a5 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> @@ -797,8 +797,7 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve
>  {
>         int32_t ret = -1;
>         SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
> -       if (service)
> -       {
> +       if (service) {
>                 VCHIQ_STATUS_T status;
>
>                 status = vchiq_get_peer_version(service->handle, peer_version);
> --
> 2.7.4
>



-- 
Jambhlekar Pushkar Arun
M.Tech IIT Roorkee