linux-kernel - Re: [PATCH v4 0/7] Xen transport for 9pfs frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d250095-b899-2449-6930-a96a0800cfe6@suse.com>
Date:   Thu, 16 Mar 2017 07:19:00 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel@...ts.xenproject.org
Cc:     linux-kernel@...r.kernel.org, konrad.wilk@...cle.com,
        boris.ostrovsky@...cle.com, ericvh@...il.com, rminnich@...dia.gov,
        lucho@...kov.net, v9fs-developer@...ts.sourceforge.net,
        groug@...d.org
Subject: Re: [PATCH v4 0/7] Xen transport for 9pfs frontend driver

On 15/03/17 20:23, Stefano Stabellini wrote:
> Hi all,
> 
> This patch series implements a new transport for 9pfs, aimed at Xen
> systems.
> 
> The transport is based on a traditional Xen frontend and backend drivers
> pair. This patch series implements the frontend, which typically runs in
> a regular unprivileged guest.
> 
> I also sent a series that implements the backend in userspace in QEMU,
> which typically runs in Dom0 (but could also run in a another guest).
> 
> The frontend complies to the Xen transport for 9pfs specification
> version 1, available here:
> 
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=docs/misc/9pfs.markdown;hb=HEAD
> 
> 
> Changes in v4:
> - code style improvements
> - use xenbus_read_unsigned when possible
> - do not leak "versions"
> - introduce BUILD_BUG_ON
> - introduce rwlock to protect the xen_9pfs_devs list
> - add review-by
> 
> Changes in v3:
> - add full copyright header to trans_xen.c
> - rename ring->ring to ring->data
> - handle gnttab_grant_foreign_access errors
> - remove ring->bytes
> - wrap long lines
> - add reviewed-by
> 
> Changes in v2:
> - use XEN_PAGE_SHIFT instead of PAGE_SHIFT
> - remove unnecessary initializations
> - fix error paths
> - fix memory allocations for 64K kernels
> - simplify p9_xen_create and p9_xen_close
> - use virt_XXX barriers
> - set status = REQ_STATUS_ERROR inside the p9_xen_response loop
> - add in-code comments
> 
> 
> Stefano Stabellini (7):
>       xen: import new ring macros in ring.h
>       xen: introduce the header file for the Xen 9pfs transport protocol
>       xen/9pfs: introduce Xen 9pfs transport driver
>       xen/9pfs: connect to the backend
>       xen/9pfs: send requests to the backend
>       xen/9pfs: receive responses
>       xen/9pfs: build 9pfs Xen transport driver
> 
>  include/xen/interface/io/9pfs.h |  40 ++++
>  include/xen/interface/io/ring.h | 131 ++++++++++
>  net/9p/Kconfig                  |   8 +
>  net/9p/Makefile                 |   4 +
>  net/9p/trans_xen.c              | 513 ++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 696 insertions(+)
>  create mode 100644 include/xen/interface/io/9pfs.h
>  create mode 100644 net/9p/trans_xen.c

I strongly recommend running checkpatch.pl to avoid style problems. This
will save us some more rounds, I guess: there are multiple style
violations in the patches which are not related to the header import
from Xen.


Juergen