linux-kernel - Re: [patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 06:51:54 +0000
From:   Okash Khawaja <okash.khawaja@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Samuel Thibault <samuel.thibault@...-lyon.org>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        Kirk Reiser <kirk@...sers.ca>, speakup@...ux-speakup.org,
        Chris Brannon <chris@...-brannons.com>
Subject: Re: [patch 4/4] staging: speakup: move those functions which do
 outgoing serial comms, into serialio.c

On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 01:41:55PM +0000, Okash Khawaja wrote:
> > This moves spk_synth_immediate and spk_serial_synth_probe functions into
> > serialio.c. These functions do outgoing serial comms. The move is a step
> > towards collecting all serial comms in serialio.c. This also renames
> > spk_synth_immediate to spk_serial_synth_immediate.
> > 
> > Code inside those functions has not been changed. Along the way, this patch
> > also fixes a couple of spots which were calling spk_synth_immediate directly,
> > so that the calls now happen via the spk_syth struct.
> > 
> > Signed-off-by: Okash Khawaja <okash.khawaja@...il.com>
> > Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>
> > 
> > Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
> 
> This patch doesn't apply to my tree at all.  The first 3 applied with
> some fuzz, so I think you are not working against linux-next. Please
> rebase your patch against linux-next, or my staging-testing branch, and
> resend so I can apply it.

Sure, will rebase against staging-testing. Just this patch or the
patch set?